Zip File Breaks with python 3.10 Beta

[anthonys]

What I’m trying to do:
Use zipfile to zip files uploaded by a user.

What I’ve tried and what’s not working:
It works with the regular python3 enviroment, but breaks in python 3.10 beta minimal. All the libraries import fine. Is there something I’m missing?
Code Sample:

import anvil.server
import anvil.media
from anvil.tables import app_tables
import shutil
import tempfile

@anvil.server.callable
def make_zip_remote(file,zip_file_name):
  with tempfile.TemporaryDirectory() as temp_dir:
    #
    # Need to Create File with open to control file name
    #
    with open(f'/tmp/{file.name}','w+') as temp_file: #TODO: BECARE BEFORE SELLING TO OTHER COMPANY. if I DONT USE tempfile, temporary files with file names that arent unique could be shared throughtout my account
      #
      # Need to make pdf a media blob
      #
      print(file.name)
      anvil.media.write_to_file(file,f'{temp_file.name}')
      shutil.copy(f'{temp_file.name}',f'{temp_dir}')
    my_zip   = shutil.make_archive(zip_file_name, 'zip', f'{temp_dir}')
    tmp_file = anvil.media.from_file(f'{my_zip}', 'text/plain')
    app_tables.files.add_row(file=tmp_file)

error

_1_ Messenger.png

`OSError: [Errno 30] Read-only file system: 'Test.zip'`

* `at /usr/local/lib/python3.10/zipfile.py:1251`
* `called from /usr/local/lib/python3.10/shutil.py:983`
* `called from /usr/local/lib/python3.10/shutil.py:1124`
* `called from Zip, line 33`
* `called from Form1, line 14`

Clone link:
share a copy of your app

[david.wylie]

Might be something to do with this maybe?

Changed in version 3.10.6: This function is now made thread-safe during creation of standard .zip and tar archives.

Taken from here :

shutil — High-level file operations

Don’t know what, but something changed in v 3.10 which might explain why it’s doing something different.

This has got to be one of the lowest quality replies I’ve ever given … bed time…

[KR1]

I’m on my phone now. I had the same problem about a month ago. Try using byte stream instead of files.

[anthonys]

Thank you for replying! Could you elaborate more?

I tried doing the following, but I definitely and implementing wrong.

import anvil.server
import anvil.media
from anvil.tables import app_tables
import shutil
import tempfile
import io

@anvil.server.callable
def make_zip_remote(file,zip_file_name):
  with tempfile.TemporaryDirectory() as temp_dir:
    #
    # Need to Create File with open to control file name
    #
    with open(f'/tmp/{file.name}','w+') as temp_file: #TODO: BECARE BEFORE SELLING TO OTHER COMPANY. if I DONT USE tempfile, temporary files with file names that arent unique could be shared throughtout my account
      #
      # Need to make pdf a media blob
      #
      print(file.name)
      buffer = io.BytesIO(file.get_bytes())
      buffer.seek(0)
      anvil.media.write_to_file(buffer,f'{temp_file.name}')
      shutil.copy(f'{temp_file.name}',f'{temp_dir}')
    my_zip   = shutil.make_archive(zip_file_name, 'zip', f'{temp_dir}')
    tmp_file = anvil.media.from_file(f'{my_zip}', 'text/plain')
    app_tables.files.add_row(file=tmp_file) 

[david.wylie]

I give up

Ignore me…

[anthonys]

Thanks for trying, I saw your code and had hope

[david.wylie]

I’m having one of those 24 hours where I type faster than I think. I’ll have it shortly I reckon

[stucork]

here’s a working version:

@anvil.server.callable
def make_zip_remote(file, zip_file_name):
    if not zip_file_name.endswith(".zip"):
        zip_file_name += ".zip"

    with tempfile.TemporaryDirectory() as temp_dir:
        with anvil.media.TempFile(file) as f_name:
            shutil.copy(f_name, temp_dir + "/" + file.name)

        with anvil.media.TempFile() as z_name:
            my_zip = shutil.make_archive(z_name, 'zip', root_dir=temp_dir)
            tmp_file = anvil.media.from_file(my_zip, 'application/zip', zip_file_name)
            app_tables.files.add_row(file=tmp_file)

[david.wylie]

I knew if I messed it up enough, a grown up would feel compelled to do it properly

I’m off for my medication …

[anthonys]

The hours of my life…

THANK YOU @stucork !

[ianbuywise]

The version I use all the time: (…in the style of your function)

import zlib

@anvil.server.callable
def make_zip_remote(file,zip_file_name):

    tmp_file = anvil.BlobMedia(
                                content_type='application/zip', 
                                content=zlib.compress(file.get_bytes(), level=9),
                                name=zip_file_name,
                                   )

    app_tables.files.add_row(file=tmp_file) 

[david.wylie]

That’s basically what I was doing - minus the brevity & simplicity - whilst also being unencumbered with the onerous weight of successfully achieving the goal

[ianbuywise]

Ah I just looked at the code you edited away, and yeah I moved on to zlib after using zipfile for many years for 2 reasons:

1. zipfile has horrible support for file streams and the library wants a place to write to disk all the time even if it isn’t using it for anything.
2. zlib is also available in javascript so we can move the compression/decompression to the client browser/cpu if the use case involves ton’s of users all hogging your anvil server module resources by zipping files that have to be transferred to or from the server module uncompressed, then worked on.

[anthonys]

I would LOVE to move this client-side!

Thank you for the suggestion. Do you know if it is part of the skript library? or do we have to do some JavaScript interfacing to get the job done?

[ianbuywise]

I avoid javascript like the plague and even I was able to use it with anvil by just following almost any of the docs for how to use javascript with anvil:

Using JavaScript

Edit: I’m going to make a clone example.

[david.wylie]

@ianbuywise

Ah I just looked at the code you edited away

(I was being silly - mine was rubbish and didn’t work at all - half me, half chatgpt, half wit…

[KR1]

Sorry for my late response. My solution you can’t move to client side anyway.

        import zipfile#creation of zip files

        zip_filename = "files.zip"
        # Create a BytesIO object to hold the zip archive
        zip_buffer = BytesIO()

        # Create the zip archive in memory
        with zipfile.ZipFile(zip_buffer, "w", zipfile.ZIP_DEFLATED) as zip_archive:
      

          # Your existing code to add the files to zip
          # y all files
          for file_ready in y:   
             
              # In case of reading from a database: Convert LazyMedia to BytesIO
                 file_ready = BytesIO()
                 file_ready.write(media_object.get_bytes())
                 file_ready.seek(0)
      
              # Add the file_ready to the zip archive with the filename
                zip_archive.writestr(filename_in_zip, file_ready.getvalue())

          zip_archive.close()
          zip_buffer.seek(0, 0)
          
          # Upload file to Anvil server
          file =anvil.BlobMedia("application/zip", content=zip_buffer.read(), name=now.strftime(f"%Y%m%d-%H-%M-%S-zip-files.zip")

[anthonys]

No need for apologies! you’re response is very appreciated!

[ianbuywise]

@ianbuywise

I’m going to make a clone example.

I posted the clone example here:

Example Zip in the client browser using JavaScript inside Anvil

From the questions found here: Here is a clone like to an example app: Did I ever mention I dislike using javascript with the fire of ten thousand suns? [image] = * (10^4) Docs are in the app, it’s not that big. Why it is useful: Trades cpu cycles / time for bandwidth. Uses the client browser to do the work so the server does not get slammed. Lets you keep large client files in storage without you having to do the work. Allows less transmission time for getting informat…